Fixed bug in Widget.finalize_construction. Fixed linting warnings.

src/application/gui/ApplicationView.ts

@@ -26,7 +26,7 @@ export class ApplicationView extends ResizableView {
         this.add(navigation_view);
         this.add(main_content_view);
 
-        this.finalize_construction();
+        this.finalize_construction(ApplicationView);
     }
 
     resize(width: number, height: number): this {

src/application/gui/MainContentView.ts

@@ -26,7 +26,7 @@ export class MainContentView extends ResizableView {
             gui_store.tool.observe(({ value }) => this.set_current_tool(value), { call_now: true }),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(MainContentView);
     }
 
     resize(width: number, height: number): this {

src/application/gui/NavigationButton.ts

@@ -24,7 +24,7 @@ export class NavigationButton extends Control {
 
         this.element.append(this.input, this.label);
 
-        this.finalize_construction();
+        this.finalize_construction(NavigationButton);
     }
 
     set checked(checked: boolean) {

src/application/gui/NavigationView.ts

@@ -72,7 +72,7 @@ export class NavigationView extends View {
             }),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(NavigationView);
     }
 
     private mousedown = (e: MouseEvent): void => {

src/core/gui/Button.ts

@@ -61,7 +61,7 @@ export class Button extends Control {
 
         this.element.append(inner_element);
 
-        this.finalize_construction();
+        this.finalize_construction(Button);
     }
 
     protected set_enabled(enabled: boolean): void {

src/core/gui/CheckBox.ts

@@ -25,7 +25,7 @@ export class CheckBox extends LabelledControl {
         this.element.onchange = () =>
             this._checked.set_val(this.element.checked, { silent: false });
 
-        this.finalize_construction();
+        this.finalize_construction(CheckBox);
     }
 
     protected set_enabled(enabled: boolean): void {

src/core/gui/ComboBox.ts

@@ -131,7 +131,7 @@ export class ComboBox<T> extends LabelledControl {
             bind_attr(down_arrow_element, "hidden", this.menu.visible),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(ComboBox);
     }
 
     protected set_enabled(enabled: boolean): void {

src/core/gui/Dialog.ts

@@ -97,7 +97,7 @@ export class Dialog extends ResizableWidget {
         this.overlay_element = div({ className: "core_Dialog_modal_overlay", tabIndex: -1 });
         this.overlay_element.addEventListener("focus", () => this.focus());
 
-        this.finalize_construction();
+        this.finalize_construction(Dialog);
     }
 
     dispose(): void {

src/core/gui/DropDown.ts

@@ -66,7 +66,7 @@ export class DropDown<T> extends Control {
             }),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(DropDown);
     }
 
     protected set_enabled(enabled: boolean): void {

src/core/gui/DurationInput.ts

@@ -14,7 +14,7 @@ export class DurationInput extends Input<Duration> {
 
         this.set_value(value);
 
-        this.finalize_construction();
+        this.finalize_construction(DurationInput);
     }
 
     protected get_value(): Duration {

src/core/gui/ErrorWidget.ts

@@ -17,6 +17,6 @@ export class ErrorWidget extends ResizableWidget {
 
         this.element.append(this.label.element);
 
-        this.finalize_construction();
+        this.finalize_construction(ErrorWidget);
     }
 }

src/core/gui/FileButton.ts

@@ -25,6 +25,6 @@ export class FileButton extends Button {
             }),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(FileButton);
     }
 }

src/core/gui/Label.ts

@@ -26,7 +26,7 @@ export class Label extends Widget {
             this.disposable(this._text.bind_to(text));
         }
 
-        this.finalize_construction();
+        this.finalize_construction(Label);
     }
 
     protected set_text(text: string): void {

src/core/gui/LazyWidget.ts

@@ -47,6 +47,6 @@ export class LazyWidget extends ResizableWidget {
             });
         }
 
-        this.finalize_construction();
+        this.finalize_construction(LazyWidget);
     }
 }

src/core/gui/Menu.ts

@@ -66,7 +66,7 @@ export class Menu<T> extends Widget {
             disposable_listener(document, "keydown", this.document_keydown),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(Menu);
     }
 
     focus(): void {

src/core/gui/NumberInput.ts

@@ -40,7 +40,7 @@ export class NumberInput extends Input<number> {
 
         this.set_value(value);
 
-        this.finalize_construction();
+        this.finalize_construction(NumberInput);
     }
 
     protected get_value(): number {

src/core/gui/RendererWidget.ts

@@ -14,14 +14,16 @@ export class RendererWidget extends ResizableWidget {
 
         this.disposable(renderer);
 
-        this.finalize_construction();
+        this.finalize_construction(RendererWidget);
     }
 
-    start_rendering(): void {
+    activate(): void {
         this.renderer.start_rendering();
+        super.activate();
     }
 
-    stop_rendering(): void {
+    deactivate(): void {
+        super.deactivate();
         this.renderer.stop_rendering();
     }
 

src/core/gui/ResultDialog.ts

@@ -54,7 +54,7 @@ export class ResultDialog extends Dialog {
             result.observe(({ value }) => this.result_changed(value), { call_now: true }),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(ResultDialog);
     }
 
     private result_changed(result?: Result<unknown>): void {

src/core/gui/Select.ts

@@ -75,7 +75,7 @@ export class Select<T> extends LabelledControl {
             }
         }
 
-        this.finalize_construction();
+        this.finalize_construction(Select);
     }
 
     protected set_enabled(enabled: boolean): void {

src/core/gui/TabContainer.ts

@@ -62,7 +62,7 @@ export class TabContainer extends ResizableWidget {
 
         this.element.append(this.bar_element, this.panes_element);
 
-        this.finalize_construction();
+        this.finalize_construction(TabContainer);
     }
 
     resize(width: number, height: number): this {

src/core/gui/Table.ts

@@ -137,7 +137,7 @@ export class Table<T> extends Widget {
             this.values.observe(this.update_footer),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(Table);
     }
 
     private create_row = (value: T, index: number): [HTMLTableRowElement, Disposable] => {

src/core/gui/TextArea.ts

@@ -43,7 +43,7 @@ export class TextArea extends LabelledControl {
 
         this.element.append(this.text_element);
 
-        this.finalize_construction();
+        this.finalize_construction(TextArea);
     }
 
     protected set_value(value: string): void {

src/core/gui/TextInput.ts

@@ -18,7 +18,7 @@ export class TextInput extends Input<string> {
 
         this.set_value(value);
 
-        this.finalize_construction();
+        this.finalize_construction(TextInput);
     }
 
     protected get_value(): string {

src/core/gui/ToolBar.ts

@@ -37,7 +37,7 @@ export class ToolBar extends Widget {
             }
         }
 
-        this.finalize_construction();
+        this.finalize_construction(ToolBar);
     }
 
     protected set_enabled(enabled: boolean): void {

src/core/gui/Widget.ts

@@ -135,8 +135,8 @@ export abstract class Widget implements Disposable {
      * constructor. When this method is called, we can refer to abstract properties that are
      * provided by subclasses.
      */
-    protected finalize_construction(): void {
+    protected finalize_construction(klass: Function): void {
-        if (Object.getPrototypeOf(this) !== this.constructor.prototype) return;
+        if (Object.getPrototypeOf(this) !== klass.prototype) return;
 
         // At this point we know `this.element` is initialized.
         if (this.options.id) {

src/core/rendering/webgl/WebglRenderer.ts

@@ -7,7 +7,7 @@ import pos_tex_frag_shader_source from "./pos_tex.frag";
 import { GfxRenderer } from "../GfxRenderer";
 import { WebglGfx, WebglMesh } from "./WebglGfx";
 import { Projection } from "../Camera";
-import { VertexFormat, VertexFormatType } from "../VertexFormat";
+import { VertexFormatType } from "../VertexFormat";
 import { SceneNode } from "../Scene";
 
 export class WebglRenderer extends GfxRenderer {

src/core/rendering/webgpu/WebgpuRenderer.ts

@@ -36,7 +36,7 @@ export async function create_webgpu_renderer(
 
     const adapter = await window.navigator.gpu.requestAdapter();
     const device = await adapter.requestDevice({
-        extensions: ["textureCompressionBC"] as any as GPUExtensionName[],
+        extensions: (["textureCompressionBC"] as any) as GPUExtensionName[],
     });
     const shader_loader = new ShaderLoader(http_client);
 

src/hunt_optimizer/gui/HelpView.ts

@@ -19,6 +19,6 @@ export class HelpView extends ResizableView {
 
     constructor() {
         super();
-        this.finalize_construction();
+        this.finalize_construction(HelpView);
     }
 }

src/hunt_optimizer/gui/HuntOptimizerView.ts

@@ -56,7 +56,7 @@ export class HuntOptimizerView extends ResizableView {
             }),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(HuntOptimizerView);
     }
 
     resize(width: number, height: number): void {

src/hunt_optimizer/gui/MethodsForEpisodeView.ts

@@ -151,7 +151,7 @@ export class MethodsForEpisodeView extends ResizableView {
             ),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(MethodsForEpisodeView);
     }
 
     dispose(): void {

src/hunt_optimizer/gui/MethodsView.ts

@@ -37,6 +37,6 @@ export class MethodsView extends TabContainer {
             ],
         });
 
-        this.finalize_construction();
+        this.finalize_construction(MethodsView);
     }
 }

src/hunt_optimizer/gui/OptimizationResultView.ts

@@ -53,7 +53,7 @@ export class OptimizationResultView extends View {
             ),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(OptimizationResultView);
     }
 
     private update_table(result?: OptimalResultModel): void {

src/hunt_optimizer/gui/OptimizerView.ts

@@ -17,6 +17,6 @@ export class OptimizerView extends ResizableView {
             this.add(new OptimizationResultView(hunt_optimizer_stores)).element,
         );
 
-        this.finalize_construction();
+        this.finalize_construction(OptimizerView);
     }
 }

src/hunt_optimizer/gui/WantedItemsView.ts

@@ -84,7 +84,7 @@ export class WantedItemsView extends View {
             ),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(WantedItemsView);
     }
 
     private create_row = (wanted_item: WantedItemModel): [HTMLTableRowElement, Disposable] => {

src/quest_editor/gui/AsmEditorToolBar.ts

@@ -30,6 +30,6 @@ export class AsmEditorToolBar extends ToolBar {
             inline_args_mode_checkbox.enabled.bind_to(asm_editor_store.has_issues.map(b => !b)),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(AsmEditorToolBar);
     }
 }

src/quest_editor/gui/AsmEditorView.ts

@@ -215,7 +215,7 @@ export class AsmEditorView extends ResizableView {
             this.enabled.bind_to(quest_runner.running.map(r => !r)),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(AsmEditorView);
     }
 
     focus(): void {

src/quest_editor/gui/DebugView.ts

@@ -127,7 +127,7 @@ export class DebugView extends ResizableView {
             ),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(DebugView);
     }
 
     private scrolled = (): void => {

src/quest_editor/gui/EntityInfoView.ts

@@ -88,7 +88,7 @@ export class EntityInfoView extends ResizableView {
             this.enabled.bind_to(ctrl.enabled),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(EntityInfoView);
     }
 
     protected set_enabled(enabled: boolean): void {

src/quest_editor/gui/EventSubGraphView.ts

@@ -73,7 +73,7 @@ export class EventSubGraphView extends View {
             }),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(EventSubGraphView);
     }
 
     protected set_enabled(enabled: boolean): void {

src/quest_editor/gui/EventView.ts

@@ -103,7 +103,7 @@ export class EventView extends View {
             add_action_dropdown.chosen.observe(({ value }) => ctrl.add_action(event, value)),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(EventView);
     }
 
     protected set_enabled(enabled: boolean): void {

src/quest_editor/gui/EventsView.ts

@@ -72,7 +72,7 @@ export class EventsView extends ResizableView {
             }),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(EventsView);
     }
 
     dispose(): void {

src/quest_editor/gui/NpcCountsView.ts

@@ -24,7 +24,7 @@ export class NpcCountsView extends ResizableView {
             ctrl.npc_counts.observe(({ value }) => this.update_view(value), { call_now: true }),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(NpcCountsView);
     }
 
     private update_view(npcs: readonly NameWithCount[]): void {

src/quest_editor/gui/NpcListView.ts

@@ -17,7 +17,7 @@ export class NpcListView extends EntityListView<NpcType> {
         );
 
         this.filter_npcs();
-        this.finalize_construction();
+        this.finalize_construction(NpcListView);
     }
 
     private filter_npcs = (): void => {

src/quest_editor/gui/ObjectListView.ts

@@ -21,7 +21,7 @@ export class ObjectListView extends EntityListView<ObjectType> {
         );
 
         this.filter_objects();
-        this.finalize_construction();
+        this.finalize_construction(ObjectListView);
     }
 
     private filter_objects = (): void => {

src/quest_editor/gui/QuestEditorRendererView.ts

@@ -52,6 +52,6 @@ export class QuestEditorRendererView extends QuestRendererView {
 
         this.renderer.init_camera_controls();
 
-        this.finalize_construction();
+        this.finalize_construction(QuestEditorRendererView);
     }
 }

src/quest_editor/gui/QuestEditorToolBarView.ts

@@ -172,6 +172,6 @@ export class QuestEditorToolBarView extends View {
             dialog.ondismiss.observe(ctrl.dismiss_result_dialog),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(QuestEditorToolBarView);
     }
 }

src/quest_editor/gui/QuestEditorView.ts

@@ -186,7 +186,7 @@ export class QuestEditorView extends ResizableView {
             }),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(QuestEditorView);
     }
 
     activate(): void {

src/quest_editor/gui/QuestInfoView.ts

@@ -94,7 +94,7 @@ export class QuestInfoView extends ResizableView {
             }),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(QuestInfoView);
     }
 
     protected set_enabled(enabled: boolean): void {

src/quest_editor/gui/QuestRendererView.ts

@@ -5,7 +5,7 @@ import { div } from "../../core/gui/dom";
 import { ResizableView } from "../../core/gui/ResizableView";
 
 export abstract class QuestRendererView extends ResizableView {
-    private readonly renderer_view: RendererWidget;
+    private readonly renderer_widget: RendererWidget;
 
     protected readonly renderer: QuestRenderer;
 
@@ -18,32 +18,20 @@ export abstract class QuestRendererView extends ResizableView {
     ) {
         super();
 
-        this.element = div({ className: className, tabIndex: -1 });
+        this.element = div({ className, tabIndex: -1 });
         this.renderer = renderer;
-        this.renderer_view = this.add(new RendererWidget(this.renderer));
+        this.renderer_widget = this.add(new RendererWidget(this.renderer));
-        this.element.append(this.renderer_view.element);
+        this.element.append(this.renderer_widget.element);
 
         this.disposables(
             quest_editor_store.debug.observe(({ value }) => (this.renderer.debug = value)),
         );
-
-        this.finalize_construction();
-    }
-
-    activate(): void {
-        this.renderer_view.start_rendering();
-        super.activate();
-    }
-
-    deactivate(): void {
-        super.deactivate();
-        this.renderer_view.stop_rendering();
     }
 
     resize(width: number, height: number): this {
         super.resize(width, height);
 
-        this.renderer_view.resize(width, height);
+        this.renderer_widget.resize(width, height);
 
         return this;
     }

src/quest_editor/gui/QuestRunnerRendererView.ts

@@ -30,6 +30,6 @@ export class QuestRunnerRendererView extends QuestRendererView {
 
         this.renderer.init_camera_controls();
 
-        this.finalize_construction();
+        this.finalize_construction(QuestRunnerRendererView);
     }
 }

src/quest_editor/gui/RegistersView.ts

@@ -121,7 +121,7 @@ export class RegistersView extends ResizableView {
             ),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(RegistersView);
     }
 
     private get_register_getter(type: RegisterDisplayType): RegisterGetterFunction {

src/quest_editor/gui/UnavailableView.ts

@@ -18,6 +18,6 @@ export class UnavailableView extends View {
 
         this.element.append(this.label.element);
 
-        this.finalize_construction();
+        this.finalize_construction(UnavailableView);
     }
 }

src/viewer/gui/ViewerView.ts

@@ -38,7 +38,7 @@ export class ViewerView extends ResizableView {
             }),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(ViewerView);
     }
 
     resize(width: number, height: number): void {

src/viewer/gui/model/CharacterClassOptionsView.ts

@@ -45,6 +45,6 @@ export class CharacterClassOptionsView extends ResizableView {
             body_select.selected.observe(({ value }) => ctrl.set_current_body(value)),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(CharacterClassOptionsView);
     }
 }

src/viewer/gui/model/CharacterClassSelectionView.ts

@@ -48,7 +48,7 @@ export class CharacterClassSelectionView<T extends { name: string }> extends Res
             ),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(CharacterClassSelectionView);
     }
 
     private list_click = (e: MouseEvent): void => {

src/viewer/gui/model/ModelToolBarView.ts

@@ -99,6 +99,6 @@ export class ModelToolBarView extends View {
             animation_frame_count_label.enabled.bind_to(enabled),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(ModelToolBarView);
     }
 }

src/viewer/gui/model/ModelView.test.ts

@@ -30,5 +30,4 @@ test("Renders correctly.", () =>
         );
 
         expect(view.element).toMatchSnapshot();
-    })
+    }));
-);

src/viewer/gui/model/ModelView.ts

@@ -20,7 +20,7 @@ export class ModelView extends ResizableView {
     private tool_bar_view: ModelToolBarView;
     private character_class_selection_view: CharacterClassSelectionView<CharacterClassModel>;
     private options_view: CharacterClassOptionsView;
-    private renderer_view: RendererWidget;
+    private renderer_widget: RendererWidget;
     private animation_selection_view: CharacterClassSelectionView<CharacterClassAnimationModel>;
 
     constructor(
@@ -41,7 +41,7 @@ export class ModelView extends ResizableView {
             ),
         );
         this.options_view = this.add(options_view);
-        this.renderer_view = this.add(new RendererWidget(renderer));
+        this.renderer_widget = this.add(new RendererWidget(renderer));
         this.animation_selection_view = this.add(
             new CharacterClassSelectionView(
                 ctrl.animations,
@@ -57,22 +57,12 @@ export class ModelView extends ResizableView {
                 { className: "viewer_model_ModelView_container" },
                 this.character_class_selection_view.element,
                 this.options_view.element,
-                this.renderer_view.element,
+                this.renderer_widget.element,
                 this.animation_selection_view.element,
             ),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(ModelView);
-    }
-
-    activate(): void {
-        this.renderer_view.start_rendering();
-        super.activate();
-    }
-
-    deactivate(): void {
-        super.deactivate();
-        this.renderer_view.stop_rendering();
     }
 
     resize(width: number, height: number): this {
@@ -85,7 +75,7 @@ export class ModelView extends ResizableView {
             container_height,
         );
         this.options_view.resize(CHARACTER_CLASS_OPTIONS_WIDTH, container_height);
-        this.renderer_view.resize(
+        this.renderer_widget.resize(
             Math.max(
                 0,
                 width -

src/viewer/gui/texture/TextureView.ts

@@ -18,14 +18,14 @@ export class TextureView extends ResizableView {
 
     private readonly tool_bar = this.add(new ToolBar(this.open_file_button));
 
-    private readonly renderer_view: RendererWidget;
+    private readonly renderer_widget: RendererWidget;
 
     constructor(ctrl: TextureController, renderer: Renderer) {
         super();
 
-        this.renderer_view = this.add(new RendererWidget(renderer));
+        this.renderer_widget = this.add(new RendererWidget(renderer));
 
-        this.element.append(this.tool_bar.element, this.renderer_view.element);
+        this.element.append(this.tool_bar.element, this.renderer_widget.element);
 
         const dialog = this.disposable(
             new ResultDialog({
@@ -46,23 +46,13 @@ export class TextureView extends ResizableView {
             dialog.ondismiss.observe(ctrl.dismiss_result_dialog),
         );
 
-        this.finalize_construction();
+        this.finalize_construction(TextureView);
-    }
-
-    activate(): void {
-        this.renderer_view.start_rendering();
-        super.activate();
-    }
-
-    deactivate(): void {
-        super.deactivate();
-        this.renderer_view.stop_rendering();
     }
 
     resize(width: number, height: number): this {
         super.resize(width, height);
 
-        this.renderer_view.resize(width, Math.max(0, height - this.tool_bar.height));
+        this.renderer_widget.resize(width, Math.max(0, height - this.tool_bar.height));
 
         return this;
     }