Made most simple quest properties editable.

src/data_formats/parsing/quest/index.test.ts

@@ -1,10 +1,10 @@
-import { ObjectType, Quest } from "../../../domain";
-import { parse_quest, write_quest_qst } from "../quest";
-import { Endianness } from "../..";
-import { BufferCursor } from "../../cursor/BufferCursor";
-import { ArrayBufferCursor } from "../../cursor/ArrayBufferCursor";
-import { walk_qst_files } from "../../../../test/src/utils";
 import { readFileSync } from "fs";
+import { Endianness } from "../..";
+import { walk_qst_files } from "../../../../test/src/utils";
+import { ObjectType, Quest } from "../../../domain";
+import { ArrayBufferCursor } from "../../cursor/ArrayBufferCursor";
+import { BufferCursor } from "../../cursor/BufferCursor";
+import { parse_quest, write_quest_qst } from "../quest";
 
 test("parse Towards the Future", () => {
     const buffer = readFileSync("test/resources/quest118_e.qst");
@@ -49,7 +49,7 @@ if (process.env["RUN_ALL_TESTS"] === "true") {
     roundtrip_test(path, file_name, buffer);
 }
 
-function roundtrip_test(path: string, file_name: string, contents: Buffer) {
+function roundtrip_test(path: string, file_name: string, contents: Buffer): void {
     test(`parse_quest and write_quest_qst ${path}`, () => {
         const orig_quest = parse_quest(new BufferCursor(contents, Endianness.Little))!;
         const test_bin = write_quest_qst(orig_quest, file_name);

src/domain/index.ts

@@ -29,7 +29,7 @@ export enum Episode {
 export const Episodes: Episode[] = enum_values(Episode);
 
 export function check_episode(episode: Episode): void {
-    if (!Episode[episode]) {
+    if (Episode[episode] == undefined) {
         throw new Error(`Invalid episode ${episode}.`);
     }
 }
@@ -80,15 +80,74 @@ export class Section {
 }
 
 export class Quest {
-    @observable id: number;
+    @observable private _id!: number;
-    @observable language: number;
+
-    @observable name: string;
+    get id(): number {
-    @observable short_description: string;
+        return this._id;
-    @observable long_description: string;
+    }
-    @observable episode: Episode;
+
-    @observable area_variants: AreaVariant[];
+    @action
-    @observable objects: QuestObject[];
+    set_id(id: number): void {
-    @observable npcs: QuestNpc[];
+        if (!Number.isInteger(id) || id < 0 || id > 4294967295)
+            throw new Error("id must be an integer greater than 0 and less than 4294967295.");
+        this._id = id;
+    }
+
+    @observable private _language!: number;
+
+    get language(): number {
+        return this._language;
+    }
+
+    @action
+    set_language(language: number): void {
+        if (!Number.isInteger(language)) throw new Error("language must be an integer.");
+        this._language = language;
+    }
+
+    @observable private _name!: string;
+
+    get name(): string {
+        return this._name;
+    }
+
+    @action
+    set_name(name: string): void {
+        if (name.length > 32) throw new Error("name can't be longer than 32 characters.");
+        this._name = name;
+    }
+
+    @observable private _short_description!: string;
+
+    get short_description(): string {
+        return this._short_description;
+    }
+
+    @action
+    set_short_description(short_description: string): void {
+        if (short_description.length > 128)
+            throw new Error("short_description can't be longer than 128 characters.");
+        this._short_description = short_description;
+    }
+
+    @observable _long_description!: string;
+
+    get long_description(): string {
+        return this._long_description;
+    }
+
+    @action
+    set_long_description(long_description: string): void {
+        if (long_description.length > 288)
+            throw new Error("long_description can't be longer than 288 characters.");
+        this._long_description = long_description;
+    }
+
+    readonly episode: Episode;
+
+    @observable readonly area_variants: AreaVariant[];
+    @observable readonly objects: QuestObject[];
+    @observable readonly npcs: QuestNpc[];
     /**
      * (Partial) raw DAT data that can't be parsed yet by Phantasmal.
      */
@@ -112,9 +171,6 @@ export class Quest {
         instructions: Instruction[],
         shop_items: number[]
     ) {
-        if (!Number.isInteger(id) || id < 0)
-            throw new Error("id should be a non-negative integer.");
-        if (!Number.isInteger(language)) throw new Error("language should be an integer.");
         check_episode(episode);
         if (!area_variants) throw new Error("area_variants is required.");
         if (!objects || !(objects instanceof Array)) throw new Error("objs is required.");
@@ -124,11 +180,11 @@ export class Quest {
         if (!instructions) throw new Error("instructions is required.");
         if (!shop_items) throw new Error("shop_items is required.");
 
-        this.id = id;
+        this.set_id(id);
-        this.language = language;
+        this.set_language(language);
-        this.name = name;
+        this.set_name(name);
-        this.short_description = short_description;
+        this.set_short_description(short_description);
-        this.long_description = long_description;
+        this.set_long_description(long_description);
         this.episode = episode;
         this.area_variants = area_variants;
         this.objects = objects;

src/scripting/assembler_messages.ts

@@ -1,6 +1,6 @@
 import { editor } from "monaco-editor";
-import { AssemblyError } from "./assembly";
 import { Instruction } from "../data_formats/parsing/quest/bin";
+import { AssemblyError } from "./assembly";
 
 export type ScriptWorkerInput = NewAssemblyInput | AssemblyChangeInput;
 
@@ -19,6 +19,6 @@ export type ScriptWorkerOutput = NewErrorsOutput;
 export type NewErrorsOutput = {
     readonly type: "new_errors_output";
     readonly instructions: Instruction[];
-    readonly labels: Map<number,number>;
+    readonly labels: Map<number, number>;
     readonly errors: AssemblyError[];
 };

src/ui/quest_editor/EntityInfoComponent.less

@@ -1,4 +1,4 @@
-.qe-EntityInfoComponent-container {
+.qe-EntityInfoComponent {
     width: 100%;
     height: 100%;
     padding: 2px 10px 10px 10px;

src/ui/quest_editor/EntityInfoComponent.tsx

@@ -48,7 +48,7 @@ export class EntityInfoComponent extends Component {
         }
 
         return (
-            <div className="qe-EntityInfoComponent-container" tabIndex={-1}>
+            <div className="qe-EntityInfoComponent" tabIndex={-1}>
                 {body}
             </div>
         );

src/ui/quest_editor/QuestInfoComponent.less

@@ -4,6 +4,7 @@
     padding: 2px 10px 10px 10px;
     display: flex;
     flex-direction: column;
+    overflow: auto;
 }
 
 .qe-QuestInfoComponent table {
@@ -11,17 +12,12 @@
     width: 100%;
 }
 
-.qe-QuestInfoComponent table tbody th {
+.qe-QuestInfoComponent textarea {
-    text-align: right;
+    font-family: 'Courier New', Courier, monospace
-    padding-right: 5px;
-}
-
-.qe-QuestInfoComponent pre {
-    padding: 8px;
-    border: solid 1px hsl(200, 10%, 30%);
-    margin: 4px 0;
 }
 
 .qe-QuestInfoComponent-npc-counts-container {
     overflow: auto;
+    min-height: 50px;
+    margin-top: 5px;
 }

src/ui/quest_editor/QuestInfoComponent.tsx

@@ -1,9 +1,10 @@
+import { Input, InputNumber } from "antd";
 import { observer } from "mobx-react";
-import React, { Component, ReactNode } from "react";
+import React, { ChangeEvent, Component, ReactNode } from "react";
-import { NpcType } from "../../domain";
+import { Episode, NpcType } from "../../domain";
 import { quest_editor_store } from "../../stores/QuestEditorStore";
-import "./QuestInfoComponent.css";
 import { DisabledTextComponent } from "../DisabledTextComponent";
+import "./QuestInfoComponent.less";
 
 @observer
 export class QuestInfoComponent extends Component {
@@ -12,7 +13,8 @@ export class QuestInfoComponent extends Component {
         let body: ReactNode;
 
         if (quest) {
-            const episode = quest.episode === 4 ? "IV" : quest.episode === 2 ? "II" : "I";
+            const episode =
+                quest.episode === Episode.IV ? "IV" : quest.episode === Episode.II ? "II" : "I";
             const npc_counts = new Map<NpcType, number>();
 
             for (const npc of quest.npcs) {
@@ -39,22 +41,57 @@ export class QuestInfoComponent extends Component {
                 <>
                     <table>
                         <tbody>
-                            <tr>
-                                <th>Name:</th>
-                                <td>{quest.name}</td>
-                            </tr>
                             <tr>
                                 <th>Episode:</th>
                                 <td>{episode}</td>
                             </tr>
                             <tr>
-                                <td colSpan={2}>
+                                <th>ID:</th>
-                                    <pre>{quest.short_description}</pre>
+                                <td>
+                                    <InputNumber
+                                        value={quest.id}
+                                        max={4294967295}
+                                        min={0}
+                                        onChange={this.id_changed}
+                                        size="small"
+                                    />
                                 </td>
                             </tr>
+                            <tr>
+                                <th>Name:</th>
+                                <td>
+                                    <Input
+                                        value={quest.name}
+                                        maxLength={32}
+                                        onChange={this.name_changed}
+                                        size="small"
+                                    />
+                                </td>
+                            </tr>
+                            <tr>
+                                <th colSpan={2}>Short description:</th>
+                            </tr>
                             <tr>
                                 <td colSpan={2}>
-                                    <pre>{quest.long_description}</pre>
+                                    <Input.TextArea
+                                        value={quest.short_description}
+                                        maxLength={128}
+                                        rows={3}
+                                        onChange={this.short_description_changed}
+                                    />
+                                </td>
+                            </tr>
+                            <tr>
+                                <th colSpan={2}>Long description:</th>
+                            </tr>
+                            <tr>
+                                <td colSpan={2}>
+                                    <Input.TextArea
+                                        value={quest.long_description}
+                                        maxLength={288}
+                                        rows={5}
+                                        onChange={this.long_description_changed}
+                                    />
                                 </td>
                             </tr>
                         </tbody>
@@ -81,4 +118,36 @@ export class QuestInfoComponent extends Component {
             </div>
         );
     }
+
+    private id_changed(value?: number): void {
+        const quest = quest_editor_store.current_quest;
+
+        if (quest && value != undefined) {
+            quest.set_id(value);
+        }
+    }
+
+    private name_changed(e: ChangeEvent<HTMLInputElement>): void {
+        const quest = quest_editor_store.current_quest;
+
+        if (quest) {
+            quest.set_name(e.target.value);
+        }
+    }
+
+    private short_description_changed(e: ChangeEvent<HTMLTextAreaElement>): void {
+        const quest = quest_editor_store.current_quest;
+
+        if (quest) {
+            quest.set_short_description(e.target.value);
+        }
+    }
+
+    private long_description_changed(e: ChangeEvent<HTMLTextAreaElement>): void {
+        const quest = quest_editor_store.current_quest;
+
+        if (quest) {
+            quest.set_long_description(e.target.value);
+        }
+    }
 }