From d51c12096ed97280d46def40b266916277fd2708 Mon Sep 17 00:00:00 2001
From: Daan Vanden Bosch <daan.v.d.bosch@gmail.com>
Date: Thu, 24 Sep 2020 17:40:58 +0200
Subject: [PATCH] Object-specific properties are now editable.

---
 .../actions/EditEntityPropAction.ts           | 28 +++++++++++++++++++
 .../controllers/EntityInfoController.ts       | 11 ++++++++
 src/quest_editor/gui/EntityInfoView.css       |  4 +++
 src/quest_editor/gui/EntityInfoView.ts        | 14 ++++++----
 .../__snapshots__/EntityInfoView.test.ts.snap | 12 ++++++--
 5 files changed, 61 insertions(+), 8 deletions(-)
 create mode 100644 src/quest_editor/actions/EditEntityPropAction.ts

diff --git a/src/quest_editor/actions/EditEntityPropAction.ts b/src/quest_editor/actions/EditEntityPropAction.ts
new file mode 100644
index 00000000..33cb91b5
--- /dev/null
+++ b/src/quest_editor/actions/EditEntityPropAction.ts
@@ -0,0 +1,28 @@
+import { Action } from "../../core/undo/Action";
+import { QuestEntityPropModel } from "../model/QuestEntityPropModel";
+import { QuestEditorStore } from "../stores/QuestEditorStore";
+import { QuestEntityModel } from "../model/QuestEntityModel";
+
+export class EditEntityPropAction implements Action {
+    readonly description: string;
+
+    constructor(
+        private readonly quest_editor_store: QuestEditorStore,
+        private readonly entity: QuestEntityModel,
+        private readonly prop: QuestEntityPropModel,
+        private readonly old_value: number,
+        private readonly new_value: number,
+    ) {
+        this.description = `Edit ${prop.name}`;
+    }
+
+    redo(): void {
+        this.prop.set_value(this.new_value);
+        this.quest_editor_store.set_selected_entity(this.entity);
+    }
+
+    undo(): void {
+        this.prop.set_value(this.old_value);
+        this.quest_editor_store.set_selected_entity(this.entity);
+    }
+}
diff --git a/src/quest_editor/controllers/EntityInfoController.ts b/src/quest_editor/controllers/EntityInfoController.ts
index 16b535e8..8a2e2bdb 100644
--- a/src/quest_editor/controllers/EntityInfoController.ts
+++ b/src/quest_editor/controllers/EntityInfoController.ts
@@ -11,6 +11,7 @@ import { euler } from "../model/euler";
 import { entity_data } from "../../core/data_formats/parsing/quest/Quest";
 import { ListProperty } from "../../core/observable/property/list/ListProperty";
 import { QuestEntityPropModel } from "../model/QuestEntityPropModel";
+import { EditEntityPropAction } from "../actions/EditEntityPropAction";
 
 const DUMMY_VECTOR = Object.freeze(new Vector3());
 const DUMMY_EULER = Object.freeze(new Euler());
@@ -173,4 +174,14 @@ export class EntityInfoController extends Controller {
                 .redo();
         }
     }
+
+    set_prop_value(prop: QuestEntityPropModel, value: number): void {
+        const entity = this.store.selected_entity.val;
+
+        if (entity) {
+            this.store.undo
+                .push(new EditEntityPropAction(this.store, entity, prop, prop.value.val, value))
+                .redo();
+        }
+    }
 }
diff --git a/src/quest_editor/gui/EntityInfoView.css b/src/quest_editor/gui/EntityInfoView.css
index 09da3870..6f44b438 100644
--- a/src/quest_editor/gui/EntityInfoView.css
+++ b/src/quest_editor/gui/EntityInfoView.css
@@ -22,3 +22,7 @@
 .quest_editor_EntityInfoView .core_NumberInput {
     width: 100%;
 }
+
+.quest_editor_EntityInfoView table.quest_editor_EntityInfoView_specific_props {
+    margin-top: -2px;
+}
diff --git a/src/quest_editor/gui/EntityInfoView.ts b/src/quest_editor/gui/EntityInfoView.ts
index 0dfc5ebb..468a008f 100644
--- a/src/quest_editor/gui/EntityInfoView.ts
+++ b/src/quest_editor/gui/EntityInfoView.ts
@@ -16,7 +16,9 @@ export class EntityInfoView extends ResizableView {
     private readonly no_entity_view = new UnavailableView("No entity selected.");
 
     private readonly standard_props_element = table();
-    private readonly specific_props_element = table();
+    private readonly specific_props_element = table({
+        className: "quest_editor_EntityInfoView_specific_props",
+    });
 
     private readonly type_element: HTMLTableCellElement;
     private readonly name_element: HTMLTableCellElement;
@@ -114,7 +116,7 @@ export class EntityInfoView extends ResizableView {
         this.rot_z_element.enabled.val = enabled;
     }
 
-    private create_prop_row(prop: QuestEntityPropModel): [HTMLTableRowElement, Disposable] {
+    private create_prop_row = (prop: QuestEntityPropModel): [HTMLTableRowElement, Disposable] => {
         const disposer = new Disposer();
 
         let min: number | undefined;
@@ -159,14 +161,16 @@ export class EntityInfoView extends ResizableView {
                 min,
                 max,
                 round_to,
-                enabled: false,
             }),
         );
 
-        disposer.add_all(value_input.value.bind_to(prop.value));
+        disposer.add_all(
+            value_input.value.bind_to(prop.value),
+            value_input.value.observe(({ value }) => this.ctrl.set_prop_value(prop, value)),
+        );
 
         const element = tr(th(`${prop.name}:`), td(value_input.element));
 
         return [element, disposer];
-    }
+    };
 }
diff --git a/src/quest_editor/gui/__snapshots__/EntityInfoView.test.ts.snap b/src/quest_editor/gui/__snapshots__/EntityInfoView.test.ts.snap
index 6ca636cc..654fcabb 100644
--- a/src/quest_editor/gui/__snapshots__/EntityInfoView.test.ts.snap
+++ b/src/quest_editor/gui/__snapshots__/EntityInfoView.test.ts.snap
@@ -161,7 +161,9 @@ exports[`Renders correctly with an entity selected.: should render a table of ed
       </td>
     </tr>
   </table>
-  <table />
+  <table
+    class="quest_editor_EntityInfoView_specific_props"
+  />
   <div
     class="quest_editor_UnavailableView"
     hidden=""
@@ -334,7 +336,9 @@ exports[`Renders correctly without an entity selected.: should render a "No enti
       </td>
     </tr>
   </table>
-  <table />
+  <table
+    class="quest_editor_EntityInfoView_specific_props"
+  />
   <div
     class="quest_editor_UnavailableView"
   >
@@ -506,7 +510,9 @@ exports[`Renders correctly without an entity selected.: should render a "No enti
       </td>
     </tr>
   </table>
-  <table />
+  <table
+    class="quest_editor_EntityInfoView_specific_props"
+  />
   <div
     class="quest_editor_UnavailableView"
   >