Put all shared build logic in precompiled gradle conventions plugins.

build.gradle.kts

@@ -1,45 +1,3 @@
-import org.jetbrains.kotlin.gradle.tasks.Kotlin2JsCompile
-import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
-
-plugins {
-    kotlin("js") version "1.5.21" apply false
-    kotlin("multiplatform") version "1.5.21" apply false
-    kotlin("plugin.serialization") version "1.5.21" apply false
-}
-
 tasks.wrapper {
     gradleVersion = "7.1.1"
 }
-
-subprojects {
-    project.extra["coroutinesVersion"] = "1.5.1"
-    project.extra["junitVersion"] = "5.7.1"
-    project.extra["kotlinLoggingVersion"] = "2.0.6"
-    project.extra["ktorVersion"] = "1.6.1"
-    project.extra["log4jVersion"] = "2.14.1"
-    project.extra["serializationVersion"] = "1.2.2"
-    project.extra["slf4jVersion"] = "1.7.30"
-
-    repositories {
-        mavenCentral()
-        maven(url = "https://kotlin.bintray.com/kotlinx/")
-    }
-
-    tasks.withType<KotlinCompile> {
-        kotlinOptions {
-            jvmTarget = "11"
-            freeCompilerArgs += listOf(
-                "-Xjvm-default=all"
-            )
-        }
-    }
-
-    tasks.withType<Kotlin2JsCompile> {
-        kotlinOptions.freeCompilerArgs += listOf(
-            "-Xopt-in=kotlin.RequiresOptIn",
-            "-Xopt-in=kotlin.ExperimentalUnsignedTypes",
-            "-Xopt-in=kotlin.contracts.ExperimentalContracts",
-            "-Xopt-in=kotlin.time.ExperimentalTime"
-        )
-    }
-}

buildSrc/build.gradle.kts

@@ -1,17 +1,12 @@
 plugins {
-    kotlin("jvm") version "1.5.21"
-    `java-gradle-plugin`
+    `kotlin-dsl`
 }
 
 repositories {
-    mavenCentral()
+    gradlePluginPortal()
 }
 
-gradlePlugin {
-    plugins {
-        create("pwPlugins") {
-            id = "world.phantasmal.gradle.js"
-            implementationClass = "world.phantasmal.gradle.PwJsPlugin"
-        }
-    }
+dependencies {
+    implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.5.21")
+    implementation("org.jetbrains.kotlin:kotlin-serialization:1.5.21")
 }

buildSrc/src/main/kotlin/world/phantasmal/OptIns.kt

@@ -0,0 +1,11 @@
+package world.phantasmal
+
+val EXPERIMENTAL_ANNOTATIONS: List<String> = listOf(
+    "kotlin.RequiresOptIn",
+    "kotlin.ExperimentalUnsignedTypes",
+    "kotlin.contracts.ExperimentalContracts",
+    "kotlin.time.ExperimentalTime",
+)
+
+val EXPERIMENTAL_ANNOTATION_COMPILER_ARGS: List<String> =
+    EXPERIMENTAL_ANNOTATIONS.map { "-Xopt-in=$it" }

buildSrc/src/main/kotlin/world/phantasmal/common.gradle.kts

@@ -0,0 +1,16 @@
+package world.phantasmal
+
+plugins {
+    kotlin("plugin.serialization") apply false
+}
+
+repositories {
+    mavenCentral()
+}
+
+project.extra["coroutinesVersion"] = "1.5.1"
+project.extra["junitVersion"] = "5.7.1"
+project.extra["kotlinLoggingVersion"] = "2.0.6"
+project.extra["ktorVersion"] = "1.6.1"
+project.extra["log4jVersion"] = "2.14.1"
+project.extra["serializationVersion"] = "1.2.2"

buildSrc/src/main/kotlin/world/phantasmal/gradle/KarmaResourcesTask.kt

@@ -1,28 +0,0 @@
-package world.phantasmal.gradle
-
-import org.gradle.api.DefaultTask
-import org.gradle.api.tasks.TaskAction
-
-/**
- * This task generates a Karma configuration in karma.config.d that ensures Karma serves files from
- * the resources directories.
- */
-open class KarmaResourcesTask : DefaultTask() {
-    private val outputFile = project.file("karma.config.d/karma.config.generated.js")
-
-    init {
-        outputs.file(outputFile)
-    }
-
-    @TaskAction
-    fun generateKarmaConfig() {
-        outputFile.outputStream().use { stream ->
-            val writer = stream.writer()
-            val path = project.projectDir.absolutePath.replace("\\", "\\\\")
-            writer.write("const PROJECT_PATH = '$path';\n\n")
-            writer.flush()
-
-            KarmaResourcesTask::class.java.getResourceAsStream("/karmaConfig.js").copyTo(stream)
-        }
-    }
-}

buildSrc/src/main/kotlin/world/phantasmal/gradle/PwJsPlugin.kt

@@ -1,20 +0,0 @@
-package world.phantasmal.gradle
-
-import org.gradle.api.Plugin
-import org.gradle.api.Project
-
-/**
- * This plugin adds a karmaResources task as dependency to the browserTest and jsBrowserTest tasks
- * as a workaround for https://youtrack.jetbrains.com/issue/KT-42923.
- */
-class PwJsPlugin : Plugin<Project> {
-    override fun apply(target: Project) {
-        val karmaResources = target.tasks.create("karmaResources", KarmaResourcesTask::class.java)
-
-        target.tasks.configureEach { task ->
-            if (task.name == "browserTest" || task.name == "jsBrowserTest") {
-                task.dependsOn(karmaResources)
-            }
-        }
-    }
-}

buildSrc/src/main/kotlin/world/phantasmal/js.gradle.kts

@@ -0,0 +1,28 @@
+package world.phantasmal
+
+plugins {
+    kotlin("js")
+    id("world.phantasmal.common")
+    id("world.phantasmal.karma-resources")
+}
+
+kotlin {
+    js {
+        compilations.all {
+            kotlinOptions {
+                freeCompilerArgs = freeCompilerArgs + EXPERIMENTAL_ANNOTATION_COMPILER_ARGS
+            }
+        }
+        browser {
+            testTask {
+                useKarma {
+                    useChromeHeadless()
+                }
+            }
+        }
+    }
+}
+
+dependencies {
+    testImplementation(kotlin("test-js"))
+}

buildSrc/src/main/kotlin/world/phantasmal/jvm.gradle.kts

@@ -0,0 +1,29 @@
+package world.phantasmal
+
+import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
+
+plugins {
+    kotlin("jvm")
+    id("world.phantasmal.common")
+}
+
+val junitVersion: String by project.extra
+val log4jVersion: String by project.extra
+
+tasks.withType<KotlinCompile>().configureEach {
+    kotlinOptions {
+        jvmTarget = "11"
+        freeCompilerArgs = freeCompilerArgs + EXPERIMENTAL_ANNOTATION_COMPILER_ARGS
+    }
+}
+
+dependencies {
+    runtimeOnly("org.apache.logging.log4j:log4j-slf4j-impl:$log4jVersion")
+
+    testImplementation(kotlin("test-junit5"))
+    testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:$junitVersion")
+}
+
+tasks.withType<Test>().configureEach {
+    useJUnitPlatform()
+}

buildSrc/src/main/kotlin/world/phantasmal/karma-resources.gradle.kts

@@ -0,0 +1,28 @@
+package world.phantasmal
+
+// This task generates a Karma configuration in karma.config.d that ensures Karma serves files from
+// the resources directories.
+// This is a workaround for https://youtrack.jetbrains.com/issue/KT-42923.
+val karmaResourcesTask = tasks.register("karmaResources") {
+    doLast {
+        val karmaConfigDir = file("karma.config.d")
+        karmaConfigDir.mkdir()
+
+        object {}::class.java.getResourceAsStream("karmaConfig.js")!!.use { karmaConfigStream ->
+            karmaConfigDir.resolve("karma.config.generated.js").outputStream().use { stream ->
+                val writer = stream.writer()
+                val path = project.projectDir.absolutePath.replace("\\", "\\\\")
+                writer.write("const PROJECT_PATH = '$path';\n\n")
+                writer.flush()
+
+                karmaConfigStream.copyTo(stream)
+            }
+        }
+    }
+}
+
+tasks.configureEach {
+    if (name == "browserTest" || name == "jsBrowserTest") {
+        dependsOn(karmaResourcesTask)
+    }
+}

buildSrc/src/main/kotlin/world/phantasmal/multiplatform.gradle.kts

@@ -0,0 +1,75 @@
+package world.phantasmal
+
+plugins {
+    kotlin("multiplatform")
+    id("world.phantasmal.common")
+    id("world.phantasmal.karma-resources")
+}
+
+val coroutinesVersion: String by project.ext
+val junitVersion: String by project.extra
+val kotlinLoggingVersion: String by project.extra
+val log4jVersion: String by project.extra
+
+kotlin {
+    js {
+        browser {
+            testTask {
+                useKarma {
+                    useChromeHeadless()
+                }
+            }
+        }
+    }
+
+    jvm {
+        compilations.all {
+            kotlinOptions {
+                jvmTarget = "11"
+            }
+        }
+    }
+
+    sourceSets {
+        all {
+            EXPERIMENTAL_ANNOTATIONS.forEach(languageSettings::useExperimentalAnnotation)
+        }
+
+        commonMain {
+            dependencies {
+                api("org.jetbrains.kotlinx:kotlinx-coroutines-core:$coroutinesVersion")
+                api("io.github.microutils:kotlin-logging:$kotlinLoggingVersion")
+            }
+        }
+
+        commonTest {
+            dependencies {
+                implementation(kotlin("test-common"))
+                implementation(kotlin("test-annotations-common"))
+            }
+        }
+
+        getByName("jsTest") {
+            dependencies {
+                implementation(kotlin("test-js"))
+            }
+        }
+
+        getByName("jvmMain") {
+            dependencies {
+                runtimeOnly("org.apache.logging.log4j:log4j-slf4j-impl:$log4jVersion")
+            }
+        }
+
+        getByName("jvmTest") {
+            dependencies {
+                implementation(kotlin("test-junit5"))
+                runtimeOnly("org.junit.jupiter:junit-jupiter-engine:$junitVersion")
+            }
+        }
+    }
+}
+
+tasks.withType<Test>().configureEach {
+    useJUnitPlatform()
+}

core/build.gradle.kts

@@ -1,52 +1,3 @@
 plugins {
-    kotlin("multiplatform")
-}
-
-val coroutinesVersion: String by project.ext
-val junitVersion: String by project.extra
-val kotlinLoggingVersion: String by project.extra
-
-tasks.withType<Test> {
-    useJUnitPlatform()
-}
-
-kotlin {
-    js {
-        browser {}
-    }
-
-    jvm()
-
-    sourceSets {
-        all {
-            languageSettings.useExperimentalAnnotation("kotlin.ExperimentalUnsignedTypes")
-        }
-
-        commonMain {
-            dependencies {
-                api("org.jetbrains.kotlinx:kotlinx-coroutines-core:$coroutinesVersion")
-                api("io.github.microutils:kotlin-logging:$kotlinLoggingVersion")
-            }
-        }
-
-        commonTest {
-            dependencies {
-                implementation(kotlin("test-common"))
-                implementation(kotlin("test-annotations-common"))
-            }
-        }
-
-        getByName("jsTest") {
-            dependencies {
-                implementation(kotlin("test-js"))
-            }
-        }
-
-        getByName("jvmTest") {
-            dependencies {
-                implementation(kotlin("test-junit5"))
-                runtimeOnly("org.junit.jupiter:junit-jupiter-engine:$junitVersion")
-            }
-        }
-    }
+    id("world.phantasmal.multiplatform")
 }

lib/build.gradle.kts

@@ -4,9 +4,8 @@ import org.snakeyaml.engine.v2.api.LoadSettings
 import java.io.PrintWriter
 
 plugins {
-    kotlin("multiplatform")
+    id("world.phantasmal.multiplatform")
     kotlin("plugin.serialization")
-    id("world.phantasmal.gradle.js")
 }
 
 buildscript {
@@ -15,67 +14,23 @@ buildscript {
     }
 }
 
-val coroutinesVersion: String by project.extra
-val junitVersion: String by project.extra
-val kotlinLoggingVersion: String by project.extra
 val serializationVersion: String by project.extra
-val slf4jVersion: String by project.extra
-
-tasks.withType<Test> {
-    useJUnitPlatform()
-}
 
 kotlin {
-    js {
-        browser {
-            testTask {
-                useKarma {
-                    useChromeHeadless()
-                }
-            }
-        }
-    }
-
-    jvm()
-
     sourceSets {
-        all {
-            languageSettings.useExperimentalAnnotation("kotlin.RequiresOptIn")
-            languageSettings.useExperimentalAnnotation("kotlin.ExperimentalUnsignedTypes")
-            languageSettings.useExperimentalAnnotation("kotlin.time.ExperimentalTime")
-        }
-
         commonMain {
             kotlin.setSrcDirs(kotlin.srcDirs + file("build/generated-src/commonMain/kotlin"))
             dependencies {
                 api(project(":core"))
-                api("org.jetbrains.kotlinx:kotlinx-coroutines-core:$coroutinesVersion")
-                api("io.github.microutils:kotlin-logging:$kotlinLoggingVersion")
                 api("org.jetbrains.kotlinx:kotlinx-serialization-core:$serializationVersion")
             }
         }
 
         commonTest {
             dependencies {
-                implementation(kotlin("test-common"))
-                implementation(kotlin("test-annotations-common"))
                 implementation(project(":test-utils"))
             }
         }
-
-        getByName("jsTest") {
-            dependencies {
-                implementation(kotlin("test-js"))
-            }
-        }
-
-        getByName("jvmTest") {
-            dependencies {
-                implementation(kotlin("test-junit5"))
-                implementation("org.slf4j:slf4j-simple:$slf4jVersion")
-                runtimeOnly("org.junit.jupiter:junit-jupiter-engine:$junitVersion")
-            }
-        }
     }
 }
 
@@ -209,6 +164,8 @@ fun paramsToCode(params: List<Map<String, Any>>, indent: Int): String {
     }
 }
 
-tasks.withType<AbstractKotlinCompile<*>> {
+// The following line results in warning "The AbstractCompile.destinationDir property has been
+// deprecated.".
+tasks.withType<AbstractKotlinCompile<*>>().configureEach {
     dependsOn(generateOpcodes)
 }

observable/build.gradle.kts

@@ -1,25 +1,9 @@
 plugins {
-    kotlin("multiplatform")
-}
-
-val junitVersion: String by project.extra
-
-tasks.withType<Test> {
-    useJUnitPlatform()
+    id("world.phantasmal.multiplatform")
 }
 
 kotlin {
-    js {
-        browser {}
-    }
-
-    jvm()
-
     sourceSets {
-        all {
-            languageSettings.useExperimentalAnnotation("kotlin.contracts.ExperimentalContracts")
-        }
-
         commonMain {
             dependencies {
                 implementation(project(":core"))
@@ -28,23 +12,8 @@ kotlin {
 
         commonTest {
             dependencies {
-                implementation(kotlin("test-common"))
-                implementation(kotlin("test-annotations-common"))
                 implementation(project(":test-utils"))
             }
         }
-
-        getByName("jsTest") {
-            dependencies {
-                implementation(kotlin("test-js"))
-            }
-        }
-
-        getByName("jvmTest") {
-            dependencies {
-                implementation(kotlin("test-junit5"))
-                runtimeOnly("org.junit.jupiter:junit-jupiter-engine:$junitVersion")
-            }
-        }
     }
 }

settings.gradle.kts

@@ -9,5 +9,5 @@ include(
     ":web:assembly-worker",
     ":web:assets-generation",
     ":web:shared",
-    ":webui"
+    ":webui",
 )

test-utils/build.gradle.kts

@@ -1,23 +1,14 @@
 plugins {
-    kotlin("multiplatform")
+    id("world.phantasmal.multiplatform")
 }
 
-val coroutinesVersion: String by project.ext
-
 kotlin {
-    js {
-        browser {}
-    }
-
-    jvm()
-
     sourceSets {
         commonMain {
             dependencies {
                 api(project(":core"))
                 api(kotlin("test-common"))
                 api(kotlin("test-annotations-common"))
-                api("org.jetbrains.kotlinx:kotlinx-coroutines-core:$coroutinesVersion")
             }
         }
 

web/assembly-worker/build.gradle.kts

@@ -1,26 +1,15 @@
 plugins {
-    kotlin("js")
+    id("world.phantasmal.js")
 }
 
 kotlin {
     js {
-        browser {
-            testTask {
-                useKarma {
-                    useChromeHeadless()
-                }
-            }
-        }
         binaries.executable()
     }
 }
 
-val kotlinLoggingVersion: String by project.extra
-
 dependencies {
     api(project(":web:shared"))
-    implementation("io.github.microutils:kotlin-logging-js:$kotlinLoggingVersion")
 
-    testImplementation(kotlin("test-js"))
     testImplementation(project(":test-utils"))
 }

web/assets-generation/build.gradle.kts

@@ -1,16 +1,11 @@
 plugins {
-    kotlin("jvm")
+    id("world.phantasmal.jvm")
 }
 
-val kotlinLoggingVersion: String by project.extra
-val log4jVersion: String by project.extra
-
 dependencies {
     implementation(project(":lib"))
     implementation(project(":web:shared"))
     implementation("org.jsoup:jsoup:1.13.1")
-    implementation("io.github.microutils:kotlin-logging:$kotlinLoggingVersion")
-    runtimeOnly("org.apache.logging.log4j:log4j-slf4j-impl:$log4jVersion")
 }
 
 tasks.register<JavaExec>("generateAssets") {
@@ -18,6 +13,6 @@ tasks.register<JavaExec>("generateAssets") {
     outputs.dir(outputFile)
 
     classpath = sourceSets.main.get().runtimeClasspath
-    main = "world.phantasmal.web.assetsGeneration.MainKt"
+    mainClass.set("world.phantasmal.web.assetsGeneration.MainKt")
     args = listOf(outputFile.absolutePath)
 }

web/build.gradle.kts

@@ -1,7 +1,6 @@
 plugins {
-    kotlin("js")
+    id("world.phantasmal.js")
     kotlin("plugin.serialization")
-    id("world.phantasmal.gradle.js")
 }
 
 kotlin {
@@ -13,20 +12,14 @@ kotlin {
             runTask {
                 devServer = devServer!!.copy(
                     open = false,
-                    port = 1623
+                    port = 1623,
                 )
             }
-            testTask {
-                useKarma {
-                    useChromeHeadless()
-                }
-            }
         }
         binaries.executable()
     }
 }
 
-val kotlinLoggingVersion: String by project.extra
 val ktorVersion: String by project.extra
 val serializationVersion: String by project.extra
 
@@ -35,13 +28,13 @@ dependencies {
     implementation(project(":webui"))
     implementation(project(":web:shared"))
 
-    implementation("io.github.microutils:kotlin-logging-js:$kotlinLoggingVersion")
     implementation("io.ktor:ktor-client-core-js:$ktorVersion")
     implementation("io.ktor:ktor-client-serialization-js:$ktorVersion")
     implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:$serializationVersion")
     implementation("org.jetbrains.kotlinx:kotlinx-datetime:0.1.1")
     implementation(npm("golden-layout", "^1.5.9"))
-    // Can't upgrade monaco-editor until https://github.com/microsoft/monaco-editor/issues/2466 is fixed.
+    // Can't upgrade monaco-editor until https://github.com/microsoft/monaco-editor/issues/2466 is
+    // fixed.
     implementation(npm("monaco-editor", "0.20.0"))
     implementation(npm("three", "^0.128.0"))
     implementation(npm("javascript-lp-solver", "0.4.17"))
@@ -50,7 +43,6 @@ dependencies {
     // Can't upgrade monaco-editor-webpack-plugin until monaco-editor is upgraded.
     implementation(devNpm("monaco-editor-webpack-plugin", "1.9.1"))
 
-    testImplementation(kotlin("test-js"))
     testImplementation(project(":test-utils"))
 }
 

web/shared/build.gradle.kts

@@ -1,18 +1,11 @@
 plugins {
-    kotlin("multiplatform")
+    id("world.phantasmal.multiplatform")
     kotlin("plugin.serialization")
 }
 
 val serializationVersion: String by project.extra
 
 kotlin {
-    js {
-        browser {
-        }
-    }
-
-    jvm()
-
     sourceSets {
         commonMain {
             dependencies {

webui/build.gradle.kts

@@ -1,11 +1,5 @@
 plugins {
-    kotlin("js")
-}
-
-kotlin {
-    js {
-        browser {}
-    }
+    id("world.phantasmal.js")
 }
 
 dependencies {
@@ -13,6 +7,5 @@ dependencies {
     api(project(":observable"))
     implementation(npm("@fortawesome/fontawesome-free", "^5.13.1"))
 
-    testImplementation(kotlin("test-js"))
     testImplementation(project(":test-utils"))
 }