Added CreateParty message.

psoserv/src/main/kotlin/world/phantasmal/psoserv/data/Account.kt

@@ -10,7 +10,8 @@ class AccountData(
     private var loggedIn: Boolean,
 ) {
     /**
-     * All access to this class' properties must synchronize on this lock.
+     * All operations on this object must synchronize on this lock. All exposed data must be deeply
+     * immutable and represent a consistent snapshot of the object's state at the time of retrieval.
      */
     private val lock = Any()
     private var _account = account

psoserv/src/main/kotlin/world/phantasmal/psoserv/data/AccountStore.kt

@@ -4,7 +4,7 @@ import mu.KLogger
 
 class AccountStore(private val logger: KLogger) {
     /**
-     * All access to this class' properties must synchronize on this lock.
+     * All operations on this object must synchronize on this lock.
      */
     private val lock = Any()
     private var nextId: Long = 1L
@@ -49,7 +49,7 @@ class AccountStore(private val logger: KLogger) {
     fun getPlayingAccountsForBlock(blockId: Int): List<PlayingAccount> =
         synchronized(lock) {
             idToAccountData.values.asSequence()
-                .mapNotNull { it.playing }
+                .mapNotNull { it.playing } // Map before filtering to avoid race condition.
                 .filter { it.blockId == blockId }
                 .toList()
         }

psoserv/src/main/kotlin/world/phantasmal/psoserv/messages/BbMessages.kt

@@ -38,6 +38,7 @@ object BbMessageDescriptor : MessageDescriptor<BbMessage> {
             0x0093 -> BbMessage.Authenticate(buffer)
             0x0095 -> BbMessage.GetCharData(buffer)
             0x00A0 -> BbMessage.ShipList(buffer)
+            0x00C1 -> BbMessage.CreateParty(buffer)
             0x01DC -> BbMessage.GuildCardHeader(buffer)
             0x02DC -> BbMessage.GuildCardChunk(buffer)
             0x03DC -> BbMessage.GetGuildCardChunk(buffer)
@@ -275,6 +276,9 @@ sealed class BbMessage(override val buffer: Buffer) : AbstractMessage(BB_HEADER_
         )
     }
 
+    // 0x00C1
+    class CreateParty(buffer: Buffer) : BbMessage(buffer)
+
     // 0x01DC
     class GuildCardHeader(buffer: Buffer) : BbMessage(buffer) {
         val guildCardSize: Int get() = int(4)

psoserv/src/main/kotlin/world/phantasmal/psoserv/servers/BlockServer.kt

@@ -123,6 +123,10 @@ class BlockServer(
                 true
             }
 
+            is BbMessage.CreateParty -> {
+                true
+            }
+
             is BbMessage.Disconnect -> {
                 // Log out and disconnect.
                 logOut()

psoserv/src/main/kotlin/world/phantasmal/psoserv/servers/Server.kt

@@ -58,6 +58,8 @@ abstract class Server(
                     // Retry after timeout.
                     continue
                 } catch (e: InterruptedException) {
+                    Thread.currentThread().interrupt()
+
                     logger.error(e) {
                         "Interrupted while trying to accept client connections on $bindPair, stopping."
                     }

psoserv/src/main/kotlin/world/phantasmal/psoserv/servers/SocketHandler.kt

@@ -189,12 +189,18 @@ abstract class SocketHandler<MessageType : Message>(
                 }
             }
         } catch (e: InterruptedException) {
-            logger.error(e) { "Interrupted while listening to $name ($sockName), closing connection." }
+            Thread.currentThread().interrupt()
+
+            logger.error(e) {
+                "Interrupted while listening to $name ($sockName), closing connection."
+            }
         } catch (e: SocketException) {
             // Don't log if we're not running anymore because that means this exception was probably
             // generated by a socket.close() call.
             if (running) {
-                logger.error(e) { "Error while listening to $name ($sockName), closing connection." }
+                logger.error(e) {
+                    "Error while listening to $name ($sockName), closing connection."
+                }
             }
         } catch (e: Throwable) {
             logger.error(e) { "Error while listening to $name ($sockName), closing connection." }
@@ -252,6 +258,9 @@ abstract class SocketHandler<MessageType : Message>(
         socket.write(buffer, 0, buffer.size)
     }
 
+    protected fun isSockedClosed(): Boolean =
+        socket.isClosed
+
     protected abstract fun processMessage(message: MessageType): ProcessResult
 
     protected open fun processRawBytes(buffer: Buffer, offset: Int, size: Int) {