Sancaros/phantasmal-world
1
0
Fork 0
mirror of https://github.com/DaanVandenBosch/phantasmal-world.git synced 2025-04-05 23:38:30 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed bug where calling SimpleListProperty.prototype.remove with an argument that did not exist in the list would corrupt the list.

Browse Source 
Caused by not checking the return value of Array.prototype.indexOf.
This commit is contained in:
jtuu 2019-11-15 13:38:09 +02:00
parent 089f450847
commit 6fc543bdff
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/core/observable/property/list/SimpleListProperty.ts
View File

@ -98,14 +98,17 @@ export class SimpleListProperty<T> extends AbstractListProperty<T>
remove(...values: T[]): void { remove(...values: T[]): void {
for (const value of values) { for (const value of values) {
const index = this.values.indexOf(value); const index = this.values.indexOf(value);
this.values.splice(index, 1);
this.finalize_update({ if (index > -1) {
type: ListChangeType.ListChange, this.values.splice(index, 1);
index,
removed: [value], this.finalize_update({
inserted: [], type: ListChangeType.ListChange,
}); index,
removed: [value],
inserted: [],
});
}
} }
} }