Sancaros/phantasmal-world
1
0
Fork 0
mirror of https://github.com/DaanVandenBosch/phantasmal-world.git synced 2025-04-05 07:18:29 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Reduced GC pressure while rotating entities.

Browse Source
This commit is contained in:
Daan Vanden Bosch 2019-09-28 21:31:04 +02:00
parent 9e2858dae2
commit 1498b37f67
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/quest_editor/model/QuestEntityModel.ts
View File

@ -5,6 +5,9 @@ import { WritableProperty } from "../../core/observable/property/WritablePropert
import { SectionModel } from "./SectionModel"; import { SectionModel } from "./SectionModel";
import { Euler, Quaternion, Vector3 } from "three"; import { Euler, Quaternion, Vector3 } from "three";
const q1 = new Quaternion();
const q2 = new Quaternion();
export abstract class QuestEntityModel<Type extends EntityType = EntityType> { export abstract class QuestEntityModel<Type extends EntityType = EntityType> {
readonly type: Type; readonly type: Type;
@ -122,15 +125,13 @@ export abstract class QuestEntityModel<Type extends EntityType = EntityType> {
const section = this.section.val; const section = this.section.val;
if (section) { if (section) {
this._world_rotation.val = new Euler().setFromQuaternion( q1.setFromEuler(rot);
new Quaternion() q2.setFromEuler(section.rotation);
.setFromEuler(section.rotation) this._world_rotation.val = new Euler().setFromQuaternion(q1.multiply(q2), "ZXY");
.multiply(new Quaternion().setFromEuler(rot)),
"ZXY",
);
} else { } else {
this._world_rotation.val = rot; this._world_rotation.val = rot;
} }
return this; return this;
} }
@ -140,12 +141,10 @@ export abstract class QuestEntityModel<Type extends EntityType = EntityType> {
const section = this.section.val; const section = this.section.val;
if (section) { if (section) {
this._rotation.val = new Euler().setFromQuaternion( q1.setFromEuler(rot);
new Quaternion() q2.setFromEuler(section.rotation);
.setFromEuler(rot) q2.inverse();
.multiply(new Quaternion().setFromEuler(section.rotation).inverse()), this._rotation.val = new Euler().setFromQuaternion(q1.multiply(q2), "ZXY");
"ZXY",
);
} else { } else {
this._rotation.val = rot; this._rotation.val = rot;
} }